Skip to content

DOC-5064 improvements to Jedis production usage advice #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

DOC-5064 improvements to Jedis production usage advice #1400

wants to merge 9 commits into from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Apr 10, 2025 •
edited by jira bot
Loading

DOC-5064

I've added four new short sections, partly based on suggestions in Ricardo Ferreira's recent blog post and an experimental "live" checklist. I've also expanded the description of timeouts a bit. All feedback is welcome, as usual, especially regarding the following points:

  • We could also add failover as a recommendation, but it is a common requirement? Might be misleading if we recommend it but most people don't need to use it.
  • I think retries are handled by connection pools but if it's worth explicitly mentioning them then I'll add a specific section.
  • Should TLS connection be a production recommendation, or is it something that people should just add if they need it?

@andy-stark-redis andy-stark-redis requested review from mortensi and a team April 10, 2025 15:02
@andy-stark-redis andy-stark-redis self-assigned this Apr 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-5064-jedis-prod-usage/develop/clients/jedis/produsage

dwdougherty
dwdougherty approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of items to validate. I like the checklist short code! Approving now so you're not held up.

@andy-stark-redis
Copy link
Contributor Author

Well spotted, @dwdougherty - thanks!

@andy-stark-redis andy-stark-redis requested a review from uglide April 22, 2025 09:01
ggivo
ggivo suggested changes Apr 29, 2025
View reviewed changes
content/develop/clients/jedis/produsage.md
JedisClientConfig clientConfig = DefaultJedisClientConfig.builder()
.connectionTimeoutMillis(2000)
.socketTimeoutMillis(2000)
.tcpKeepAlive(true)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tcpKeepAlive is by default through when using DefaultJedisSocketFactory and is not externally configurable.
DefaultJedisClientConfig does not expose tcpKeepAlive(true) method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggivo ggivo ggivo requested changes

@dwdougherty dwdougherty dwdougherty approved these changes

@mortensi mortensi Awaiting requested review from mortensi

@uglide uglide Awaiting requested review from uglide

Assignees

@andy-stark-redis andy-stark-redis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy-stark-redis @dwdougherty @ggivo